Skip to content

Refactor basic block detection into standalone utility module #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tautschnig wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactor basic block detection into standalone utility module #8781

tautschnig wants to merge 1 commit into from

Conversation

@tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Nov 30, 2025

This PR refactors the basic block detection functionality from the coverage goal instrumenter into a standalone utility module in the src/analyses/ directory. The new utility provides a generic, reusable interface for basic block detection across different parts of the codebase, similar to how natural_loops_templatet handles loop detection.

Fixes: #1686

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Nov 30, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.28571% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.01%. Comparing base (1505c36) to head (22941f4).

Files with missing lines Patch % Lines
src/goto-instrument/cover_basic_blocks.cpp 85.71% 5 Missing ⚠️
src/analyses/basic_blocks_impl.h 97.29% 2 Missing ⚠️
src/analyses/basic_blocks.h 96.77% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #8781   +/-   ##
========================================
  Coverage    80.00%   80.01%           
========================================
  Files         1700     1702    +2     
  Lines       188254   188317   +63     
  Branches        73       73           
========================================
+ Hits        150615   150679   +64     
+ Misses       37639    37638    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig
Refactor basic block detection into standalone utility module
22941f4 
This PR refactors the basic block detection functionality from the
coverage goal instrumenter into a standalone utility module in the
`src/analyses/` directory. The new utility provides a generic, reusable
interface for basic block detection across different parts of the
codebase, similar to how `natural_loops_templatet` handles loop
detection.

Fixes: diffblue#1686
@tautschnig tautschnig force-pushed the fix-1686-basic-block-refactor branch from d00c236 to 22941f4 Compare December 2, 2025 16:19
@tautschnig tautschnig marked this pull request as ready for review December 2, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@kroening kroening Awaiting requested review from kroening kroening is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kroening kroening

@peterschrammel peterschrammel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor basic block detection of coverage goal instrumenter

3 participants

@tautschnig @kroening @peterschrammel